Alon Bar-Lev has posted comments on this change. Change subject: core : Allow redirection of all logs to syslog using extension ......................................................................
Patch Set 7: (2 comments) last two minor issues! http://gerrit.ovirt.org/#/c/27431/7/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/logger/Logger.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/logger/Logger.java: Line 6: import java.util.logging.LogRecord; Line 7: Line 8: /** Line 9: * Extensions that provide Logger will be invoked to log messages as configured Line 10: * in ovirt-engine.xml.in nobody knows what is ovirt-engine.xml.in :)))) Something like: Log extension interface. Permitted to process logging records of application. Line 11: */ Line 12: public class Logger { Line 13: /** Line 14: * Invoke keys. http://gerrit.ovirt.org/#/c/27431/7/backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java File backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java: Line 56: } Line 57: } Line 58: Line 59: public void setRefreshInterval(final long refreshInterval) { Line 60: REFRESH_INTERVAL_IN_SECONDS = refreshInterval; if it is not constant, please convert to lower case? Line 61: } Line 62: Line 63: private void initRefreshThread() { Line 64: if (exec == null) { -- To view, visit http://gerrit.ovirt.org/27431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
