Yair Zaslavsky has posted comments on this change.
Change subject: core: Use the hostSpmId during reconstructMaster
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ReconstructMasterVDSCommand.java
Line 28: if (vdsVersion.compareTo(new Version("4.10")) < 0) {
Sorry for stepping in, as someone who got involved at the Version issue , I do
not like the fact you're using version 4.10 (in general, I don't like the fact
that we still can't support version 4.9.6 ).
I would recommend you have this version configurable (i.e - uise vdc_options).
I hope that once we solve the format issue for software_version you guys will
be able not to use 2 numbers format anymore.
--
To view, visit http://gerrit.ovirt.org/4967
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8c4fceeda898e020a4153ccd36aa078eb200ac3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
