Jason Liao has posted comments on this change. Change subject: engine: NUMA feature actions and queries ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/26810/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 109: Line 110: // NUMA Line 111: AddVmNumaNode(170, ActionGroup.EDIT_VM_PROPERTIES, false, QuotaDependency.NONE), Line 112: UpdateVmNumaNode(171, ActionGroup.EDIT_VM_PROPERTIES, false, QuotaDependency.NONE), Line 113: RemoveVmNumaNode(172, ActionGroup.EDIT_VM_PROPERTIES, false, QuotaDependency.NONE), > thought about it, this is not a question anymore. the operation should be t I will change them to plural. Line 114: Line 115: // VmTemplatesCommand Line 116: AddVmTemplate(201, ActionGroup.CREATE_TEMPLATE, QuotaDependency.BOTH), Line 117: UpdateVmTemplate(202, ActionGroup.EDIT_TEMPLATE_PROPERTIES, QuotaDependency.VDS_GROUP), http://gerrit.ovirt.org/#/c/26810/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 86: GetNetworkLabelsByDataCenterId, Line 87: GetNetworkLabelsByHostNicId, Line 88: Line 89: // NUMA Line 90: GetVdsNumaNodeByVdsId(VdcQueryAuthType.User), > s/GetVdsNumaNodeByVdsId/GetVdsNumaNode(s/List)ByVdsId Yes, I will change them Line 91: GetVmNumaNodeByVmId(VdcQueryAuthType.User), Line 92: GetVmNumaNodeByVdsNumaNodeId(VdcQueryAuthType.User), Line 93: Line 94: // VdsGroups Line 88: Line 89: // NUMA Line 90: GetVdsNumaNodeByVdsId(VdcQueryAuthType.User), Line 91: GetVmNumaNodeByVmId(VdcQueryAuthType.User), Line 92: GetVmNumaNodeByVdsNumaNodeId(VdcQueryAuthType.User), > Thinking what is possible via the RESTful API and needed by the GUI: I will add type of GetVmsWithNumaByClusterId, is that OK? Line 93: Line 94: // VdsGroups Line 95: GetVdsCertificateSubjectByVdsId(VdcQueryAuthType.User), Line 96: GetVdsCertificateSubjectByVmId(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/26810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f297311a49c051b7ae2daee540d96210bf1a66d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
