Gilad Chaplik has posted comments on this change. Change subject: engine: NUMA feature actions and queries ......................................................................
Patch Set 5: (1 comment) Well Done. only one inline comment for now. please add all audit log messages. you can get examples from other commands. http://gerrit.ovirt.org/#/c/26810/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/GetAllVmsWithNumaByVdsGroupIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/GetAllVmsWithNumaByVdsGroupIdQuery.java: Line 17: Line 18: @Override Line 19: protected void executeQueryCommand() { Line 20: List<VM> vms = getDbFacade().getVmDao().getAllForVdsGroup(getParameters().getId()); Line 21: List<Pair<Guid, VmNumaNode>> nodes = getDbFacade().getVmNumaNodeDAO().GetAllVmNumaNodeInfo(); -1, ALL?? Line 22: for (VM vm : vms) { Line 23: for (Pair<Guid, VmNumaNode> pairnode : nodes) { Line 24: if (vm.getId().equals(pairnode.getFirst())) { Line 25: vm.getvNumaNodeList().add(pairnode.getSecond()); -- To view, visit http://gerrit.ovirt.org/26810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f297311a49c051b7ae2daee540d96210bf1a66d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
