Xiaolei Shi has posted comments on this change. Change subject: restapi: NUMA feature restful API support ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26943/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4160: </xs:complexType> Line 4161: Line 4162: <xs:complexType name="VirtualNumaNode"> Line 4163: <xs:complexContent> Line 4164: <xs:extension base="BaseDevice"> > The two base data structure are BaseResource and BaseDevice. As Jason said, BaseResource and BaseDevice are the only base classes in restful, all othere restful objects should extend one of the base classes.(Is that right?) Base on this point, pNuma should extend BaseResource because it can't modified by user; vNuma should extend BaseDevice since it can be modified by user. I think it's the rule in restful api.(Is it right? @Juan) If follow Gilad's suggestion, vNuma extend pNuma, that means vNuma and pNuma should both extend BaseDevice(because only BaseDevice can be modified), in other word, pNuma is able to be modified(althought we will not implement the modify functions in actual). Is this reasonable? Line 4165: <xs:sequence> Line 4166: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4167: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4168: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> -- To view, visit http://gerrit.ovirt.org/26943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
