Jason Liao has posted comments on this change. Change subject: restapi: NUMA feature restful API support ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/26943/5/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1536: <!-- Optionally specify the display address of this host explicitly --> Line 1537: <xs:element ref="display" minOccurs="0"/> Line 1538: <xs:element name="hosted_engine" type="HostedEngine" minOccurs="0" maxOccurs="1"/> Line 1539: <xs:element name="kdump_status" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 1540: <xs:element name="auto_numa_status" type="xs:string" minOccurs="0" maxOccurs="1"/> > all enums should be exposed in API. What is exposed meaning? I follow other resfful API enums do the same design. Line 1541: <xs:element name="numa_supported" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1542: </xs:sequence> Line 1543: </xs:extension> Line 1544: </xs:complexContent> Line 2806: <xs:element ref="reported_devices" minOccurs="0" maxOccurs="1"/> Line 2807: <xs:element ref="watchdogs" minOccurs="0" maxOccurs="1"/> Line 2808: <xs:element name="use_latest_template_version" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 2809: <xs:element ref="serial_number" minOccurs="0" maxOccurs="1" /> Line 2810: <xs:element name="numa_tune_mode" type="xs:string" minOccurs="0" maxOccurs="1"/> > in db its numatune_mode. please use the same naming convention. I think @Juan prefer split the words in prev comments. Line 2811: </xs:sequence> Line 2812: </xs:extension> Line 2813: </xs:complexContent> Line 2814: </xs:complexType> Line 4179: <xs:sequence> Line 4180: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4181: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4182: <xs:element name="numa_cpus" type="NumaCPUs" minOccurs="0" maxOccurs="1"/> Line 4183: <xs:element name="numa_node_pins" type="NumaNodePins" minOccurs="0" maxOccurs="1"/> > we need to discuss on cpu pinning, please consider separating to another pa I will do it. Line 4184: </xs:sequence> Line 4185: </xs:extension> Line 4186: </xs:complexContent> Line 4187: </xs:complexType> Line 4236: <xs:complexType name="NumaCPU"> Line 4237: <xs:attribute name="index" type="xs:int" use="required"/> Line 4238: <xs:attribute name="socket" type="xs:int" use="optional"/> Line 4239: </xs:complexType> Line 4240: > trailing white space. Thanks for your mentioned -- To view, visit http://gerrit.ovirt.org/26943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
