Alon Bar-Lev has posted comments on this change. Change subject: core : Allow redirection of all logs to syslog using extension ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27431/11/backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java File backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java: Line 65: private List<ExtensionProxy> getExtensions() { Line 66: if (extensions == null) { Line 67: extensions = ExtensionsManager.getInstance().getProvidedExtensions(Logger.class.getName()); Line 68: } Line 69: return extensions; so there is no need for this... at constructor call update(null, null)... and put at member... you get empty collection and all is ok. use only the extensions member all over. Line 70: } Line 71: Line 72: @Override Line 73: public void update(Observable o, Object arg) { -- To view, visit http://gerrit.ovirt.org/27431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
