Maor Lipchuk has posted comments on this change. Change subject: core: Add vdc query to check if an entity if unregistered. ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/26484/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 7: IsVmWithSameNameExist(VdcQueryAuthType.User), Line 8: GetVmByVmId(VdcQueryAuthType.User), Line 9: GetVmByVmNameForDataCenter(VdcQueryAuthType.User), Line 10: GetAllVms(VdcQueryAuthType.User), Line 11: GetUnregisteredVms(VdcQueryAuthType.User), > I don't think these queries should be exposed for users, but if they do, yo done Line 12: GetUnregisteredVmTemplates(VdcQueryAuthType.User), Line 13: GetVmsRunningOnOrMigratingToVds, Line 14: GetVmsByStorageDomain, Line 15: GetVmsByInstanceTypeId, http://gerrit.ovirt.org/#/c/26484/11/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java: Line 32: Line 33: @Override Line 34: public Templates list() { Line 35: Templates templates = new Templates(); Line 36: if (QueryHelper.hasMatrixParam(getUriInfo(), UNREGISTERED_CONSTRAINT_PARAMETER)) { > imo, the rest-api changes should be extracted to a different patch. done Line 37: List<org.ovirt.engine.core.common.businessentities.VmTemplate> unregisteredTemplates = Line 38: getBackendCollection(VdcQueryType.GetUnregisteredVmTemplates, new IdAndNameQueryParameters(storageDomainId, Line 39: "Template")); Line 40: List<Template> collection = new ArrayList<Template>(); -- To view, visit http://gerrit.ovirt.org/26484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83a937dcc8cd86d7f88f643bb7ba0f03d27a8ee6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
