Oved Ourfali has posted comments on this change.

Change subject: core: long query response time while many simultaneously 
queries are running
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/27586/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDao.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDao.java:

Line 22:      * @param requiredDisks
Line 23:      *            The images to load
Line 24:      * @return A Map of the images and their image group ids
Line 25:      */
Line 26:     public Map<Guid, Guid> getImageIdForDisks(List<Guid> 
requiredDisks);
The name here is a bit challenging.
Maybe change to:
getImageGroupIdMapForImageList

Let's wait for other thoughts/opinoins on that.


-- 
To view, visit http://gerrit.ovirt.org/27586
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to