Roy Golan has posted comments on this change.

Change subject: core: long query response time while many simultaneously 
queries are running
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/27586/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java:

Line 165:         private ImageAndImageGroupIdMapper() {
Line 166:         }
Line 167: 
Line 168:         @Override
Line 169:         public ImageAndImageGroupId mapRow(ResultSet rs, int rowNum) 
throws SQLException {
> No, we can't - as the only supported return values from CallsHandler are T 
maybe

 m = new Rowmapper<Pair<Guid,Guid>> {
 
 @override
 public Pair<Guid,Guid> mapRow(ResultSet rs, int roNum) {
    return new Pair(
         getGuidDefaultEmpty(rs, "image_guid"), 
         getGuidDefaultEmpty(rs, "image_group_id"))
    }
}

and now you got a a List<Pair<G,G> and just convert this to map
Line 170:             ImageAndImageGroupId entity = new ImageAndImageGroupId();
Line 171:             entity.setImageId(getGuidDefaultEmpty(rs, "image_guid"));
Line 172:             entity.setImageGroupId(getGuidDefaultEmpty(rs, 
"image_group_id"));
Line 173:             return entity;


-- 
To view, visit http://gerrit.ovirt.org/27586
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to