Livnat Peer has posted comments on this change. Change subject: core: Enable VLAN & no network over bond (#826401) ......................................................................
Patch Set 3: Looks good to me, approved (3 inline comments) please fix formatting and documentation before merging. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java Line 235: */ Please fix the formatting .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java Line 243: * <br> Please change the documentation to fit the code.test case 1 is not accurate. Line 322: isn't this test case a duplication of extractBond testcase1? -- To view, visit http://gerrit.ovirt.org/5056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03457629327e6b0f9b3c9e575f8ad76bd8f9e62f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
