Alon Bar-Lev has posted comments on this change. Change subject: packaging: allow to override sos version ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/27691/3/configure.ac File configure.ac: Line 66: AX_PYTHON_MODULE([ovirtsdk]) Line 67: AX_PYTHON_MODULE([sos], [fatal]) Line 68: Line 69: AC_MSG_CHECKING(sos version) Line 70: LOCAL_SOS_VERSION=`` any reason you execute anything? and why do you need this LOCAL_SOS_VERSION? Line 71: AC_ARG_WITH( Line 72: [sos-version], Line 73: [AS_HELP_STRING([--with-sos-version], [sos version to use])], Line 74: [SOS_VERSION="${withval}"], Line 71: AC_ARG_WITH( Line 72: [sos-version], Line 73: [AS_HELP_STRING([--with-sos-version], [sos version to use])], Line 74: [SOS_VERSION="${withval}"], Line 75: [SOS_VERSION="$(${PYTHON} -c "import sos; print(sos.__version__)" |cut -c1 2>/dev/null)"] any reason why you left the cut? Line 76: ) Line 77: AC_MSG_RESULT($SOS_VERSION) Line 78: Line 79: AM_CONDITIONAL([SOS2], [test x"${SOS_VERSION}" == x2]) -- To view, visit http://gerrit.ovirt.org/27691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6cd685f5bf7f7c1b49dc769e46bb6aa3adfff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
