Sandro Bonazzola has posted comments on this change. Change subject: packaging: allow to override sos version ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27691/4/configure.ac File configure.ac: Line 70: AC_ARG_WITH( Line 71: [sos-version], Line 72: [AS_HELP_STRING([--with-sos-version], [sos version to use])], Line 73: [SOS_VERSION="${withval}"], Line 74: [SOS_VERSION="$(${PYTHON} -c "import sos; print(sos.__version__)" |cut -c1 2>/dev/null)"] > and why use cut? using suggeested split doesn't work: checking python module: sos... yes checking sos version... I'm still trying to understand if it's due to quoting around '.' but while it's working in python shell it doesn't work when run by configure Line 75: ) Line 76: AC_MSG_RESULT($SOS_VERSION) Line 77: Line 78: AM_CONDITIONAL([SOS2], [test x"${SOS_VERSION}" == x2]) -- To view, visit http://gerrit.ovirt.org/27691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6cd685f5bf7f7c1b49dc769e46bb6aa3adfff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
