Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Introduce application_name key
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.ovirt.org/#/c/27725/2/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java
File 
backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java:

Line 158:         public static final ExtKey EXTENSIONS = new 
ExtKey("GLOBAL_EXTENSIONS", List/*<ExtMap>*/.class, 
"246498c0-2f4d-4135-8cb7-c5eabfd2f6ff");
Line 159: 
Line 160:         /**
Line 161:          * Application name.
Line 162:          * @See ApplicationName
> @see
Done
Line 163:          */
Line 164:         public static final ExtKey APPLICATION_NAME = new 
ExtKey("GLOBAL_APPLICATION_NAME", String.class, 
"913655b7-1bc9-43b8-9a3a-18330e288708");
Line 165:     }
Line 166: 


Line 167:     /**
Line 168:      * Application names
Line 169:      *
Line 170:      */
Line 171:     public static class ApplicationName {
> ApplicationNames?
Done
Line 172:         public static final String ENGINE = "engine";
Line 173:         public static final String EXTENSION_TESTER = 
"extension-tester";
Line 174:     }
Line 175: 


Line 168:      * Application names
Line 169:      *
Line 170:      */
Line 171:     public static class ApplicationName {
Line 172:         public static final String ENGINE = "engine";
> copying from above... OVIRT_ENGINE
Done
Line 173:         public static final String EXTENSION_TESTER = 
"extension-tester";
Line 174:     }
Line 175: 
Line 176:     /**


Line 169:      *
Line 170:      */
Line 171:     public static class ApplicationName {
Line 172:         public static final String ENGINE = "engine";
Line 173:         public static final String EXTENSION_TESTER = 
"extension-tester";
> OVIRT_ENGINE_AAA_EXTENSION_TOOL
Done
Line 174:     }
Line 175: 
Line 176:     /**
Line 177:      * Context keys.


-- 
To view, visit http://gerrit.ovirt.org/27725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ba68584362c85b1e73763ab07cb41c792c0254b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to