Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introduce application_name key ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/27725/5/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java: Line 158: public static final ExtKey EXTENSIONS = new ExtKey("GLOBAL_EXTENSIONS", List/*<ExtMap>*/.class, "246498c0-2f4d-4135-8cb7-c5eabfd2f6ff"); Line 159: Line 160: /** Line 161: * Application name. Line 162: * I usually do not add space lines..... but not critical. Line 163: * @see ApplicationNames Line 164: */ Line 165: public static final ExtKey APPLICATION_NAME = new ExtKey("GLOBAL_APPLICATION_NAME", String.class, "913655b7-1bc9-43b8-9a3a-18330e288708"); Line 166: } Line 166: } Line 167: Line 168: /** Line 169: * Application names Line 170: * oh... this should be with dot, no? and space is not needed. /** Application names. */ Line 171: */ Line 172: public static class ApplicationNames { Line 173: public static final String OVIRT_ENGINE = "ovirt-engine"; Line 174: public static final String OVIRT_ENGINE_AAA_EXTENSION_TOOL = "ovirt-engine-aaa-extension-tool"; -- To view, visit http://gerrit.ovirt.org/27725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ba68584362c85b1e73763ab07cb41c792c0254b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
