Alon Bar-Lev has posted comments on this change. Change subject: aaa: Chages to ExtensionsManager ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27785/7/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 117: private Map<String, BindingsLoader> bindingsLoaders = new HashMap<>(); Line 118: private Map<String, ExtensionEntry> loadedEntries = new HashMap<>(); Line 119: private ExtMap globalContext = new ExtMap().mput(Base.GlobalContextKeys.EXTENSIONS, new ArrayList<ExtMap>()); Line 120: Line 121: private Properties configProperties = new Properties(); > Like what ? I have chosen properties due to the ability to getProperty(key, I do not like we share the structure between engine and this class. the fact that engine holds this in properties in specific format should not exposed to this class. Line 122: Line 123: public ExtMap getGlobalContext() { Line 124: return globalContext; Line 125: } -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
