Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Chages to ExtensionsManager
......................................................................
Patch Set 8:
About:
ok... I suggest:
1. loadExtension() - just load... do not call initialize.
2. enableExtension() - perform initialize.
This way the caller is:
for (x : files) {
loadExtension(x);
}
for (x : extensions) {
if (not explicit_disable && extension_enabled) {
enableExtension(x);
}
}
Why?
In the past, in one of the patchsets of ExtensionManager there was this
separation, and we decided to cancel it.
What benefit would I have from loading an extension if I do not try to enable
it?
--
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
