Tal Nisan has posted comments on this change.
Change subject: core: Remove obsolete StringUtils class from utils package
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
Line 69: * @param storageIds
Forgot to update the comment, the original method was called "getStorageIdList"
for some reason, although it was a general String to Guid list transformer
Line 73: public static ArrayList<Guid> getGuidListFromString(String str) {
I figured it might come in handy to have it both ways, either from a String or
a list of String, the only cost is extracting a part of the logic to another
method which is mostly never a bad thing
Line 90: if (CollectionUtils.isEmpty(strings)) {
Indeed, changed it from !StringHelper.isNullOrEmpty due to a comment and sent
to review, missed the !
--
To view, visit http://gerrit.ovirt.org/5214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib74df28b0bc2c65449eb92c5146fffe4ad8a2e6f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
