Michael Kublin has posted comments on this change. Change subject: core: Remove obsolete StringUtils class from utils package ......................................................................
Patch Set 4: I would prefer that you didn't submit this (2 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java Line 234: How XmlRpcUtils is connected to the added code ? What is connection between public static Map<String, String> string2Map(String str) and XmlRpcUtils. Idea of XmlRpcUtils is manage XmlRpcUtils connections and factories, I don't see any connection to strings. .................................................... File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtilsTest.java Line 15: @Rule These code never should be written. XmlRpcUtilsTest is checking some string manipulations which are not related to XmlRpc calls? How these can be? -- To view, visit http://gerrit.ovirt.org/5214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib74df28b0bc2c65449eb92c5146fffe4ad8a2e6f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
