Michael Pasternak has posted comments on this change. Change subject: restapi: Support max result num for queries ......................................................................
Patch Set 4: (3 inline comments) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java Line 81: searchParams.setMaxCount(getMaxResults()); are you sure this will handle well Integer.MAX_VALUE on not convertible int ? .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java Line 121: return Integer.MAX_VALUE; i'd return -1 instead and use List.size if returned -1, otherwise someone reusing your code will not be aware of MAX_VALUE returned and get IndexOutOfBoundsException Line 124: return Integer.MAX_VALUE; same here -- To view, visit http://gerrit.ovirt.org/2902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc545e7084d6e34aca5c62a448575daf68960fd9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
