Ori Liel has posted comments on this change. Change subject: restapi: Support max result num for queries ......................................................................
Patch Set 4: (2 inline comments) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java Line 81: searchParams.setMaxCount(getMaxResults()); what's a not convertible int? Anyway, I'm changing to return -1 in case of no limit, like you asked in your other comment, so this comment should be irrelevant now. .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java Line 121: return Integer.MAX_VALUE; This method is called before the query is run, so it's not possible to pass list.size() (as we don't have results yet). I don't see why a programmer would look for an item in some index and get IndexOutOfBoundsException, based on the output of this method, but I have no objection for the method to return -1, so I'll make the change anyway -- To view, visit http://gerrit.ovirt.org/2902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc545e7084d6e34aca5c62a448575daf68960fd9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
