Yair Zaslavsky has posted comments on this change. Change subject: engine : Introduction of CallBack interface ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/26333/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java: Line 76: private static volatile AsyncTaskManager taskManager; Line 77: private static final Object LOCK = new Object(); Line 78: private CommandCoordinator coco; Line 79: Line 80: public static AsyncTaskManager getInstance(CommandCoordinator coco) { Do we need another getInstance() method that takes no arguments, for getting the AsyncTaskManager where needed? (getting and not creating). Line 81: if (taskManager == null) { Line 82: synchronized(LOCK) { Line 83: if (taskManager == null) { Line 84: taskManager = new AsyncTaskManager(coco); http://gerrit.ovirt.org/#/c/26333/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CallBack.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CallBack.java: Line 5: import org.ovirt.engine.core.common.action.VdcReturnValueBase; Line 6: import org.ovirt.engine.core.common.businessentities.AsyncTasks; Line 7: import org.ovirt.engine.core.compat.Guid; Line 8: Line 9: public interface CallBack { I think I commented in the past, and if not - now is the time, I think CallBack is a too general name, can you please change it so we will have better understanding of what kind of what kind of Callback this is? Line 10: public VdcReturnValueBase endAction(Guid stepId, VdcActionType actionType, AsyncTasks dbAsyncTask, ExecutionContext context); -- To view, visit http://gerrit.ovirt.org/26333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c12315c96168fd32dc05ac6de336ccdd63c9fbc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
