Liron Ar has posted comments on this change. Change subject: core: adding DAO support for unregistered VMs/Templates. ......................................................................
Patch Set 15: (3 comments) http://gerrit.ovirt.org/#/c/26480/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OvfEntityData.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OvfEntityData.java: Line 78: public void setOvfData(String ovfData) { Line 79: this.ovfData = ovfData; Line 80: } Line 81: Line 82: public String getOvfExtraData() { > field for data which does not exists in the OVF such as cluster name, Data I'd remove it for now, if we'll ever need it we can add it..right now it's field which is never used and we don't know if it will ever be. Line 83: return ovfExtraData; Line 84: } Line 85: Line 86: public void setOvfExtraData(String ovfExtraData) { http://gerrit.ovirt.org/#/c/26480/15/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 3596: <column>storage_domain_id</column> Line 3597: <column>ovf_data</column> Line 3598: <column>ovf_extra_data</column> Line 3599: <row> Line 3600: <value>77296e00-0cad-4e5a-9299-008a7b6f4354</value> I missed that in the previous round, i'd suggest/prefer that you used a different ID here which is not id of vm that exists on the "regular" vm tables to simulate a real situation. Line 3601: <value>rhel5-pool-50</value> Line 3602: <value>VM</value> Line 3603: <value>1</value> Line 3604: <value>3.4</value> http://gerrit.ovirt.org/#/c/26480/15/packaging/dbscripts/unregistered_OVF_data_sp.sql File packaging/dbscripts/unregistered_OVF_data_sp.sql: Line 16: Line 17: UPDATE unregistered_ovf_of_entities u Line 18: SET ovf_data = vog.ovf_data Line 19: FROM vm_ovf_generations vog Line 20: WHERE vog.vm_guid = u.entity_guid AND u.entity_guid = v_entity_guid; why the motivation for not doing that in the insert statement instead of update? Line 21: END; $procedure$ Line 22: LANGUAGE plpgsql; Line 23: Line 24: -- To view, visit http://gerrit.ovirt.org/26480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
