Liron Ar has posted comments on this change. Change subject: core: adding DAO support for unregistered VMs/Templates. ......................................................................
Patch Set 16: (4 comments) http://gerrit.ovirt.org/#/c/26480/16/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAO.java: Line 18: */ Line 19: public OvfEntityData getByEntityIdAndStorageDomain(Guid entityId, Guid storageDomainId); Line 20: Line 21: /** Line 22: * Retrieves all the entities of type OvfEntityData related to the storage Domain Id. /s/of type OvfEntityData/of the given type Line 23: * Line 24: * @param storageDomainId Line 25: * The Storage Domain Id. Line 26: * @param entityType Line 26: * @param entityType Line 27: * The entity type (VM/Template). Line 28: * @return List of all the OvfEntityData related to the storage Domain Id, or an empty list if none is found. Line 29: */ Line 30: public List<OvfEntityData> getAllForStorageDomainByEntityType(Guid storageDomainId, String entityType); better to get here the VmEntityType to avoid mistakes, same as being done in VmTemplateDAO Line 31: Line 32: /** Line 33: * Insert new entity to the unregistered table. Line 34: */ http://gerrit.ovirt.org/#/c/26480/16/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java: Line 46: .addValue("entity_type", ovfEntityData.getEntityType().name()) Line 47: .addValue("architecture", ovfEntityData.getArchitecture().getValue()) Line 48: .addValue("lowest_comp_version", ovfEntityData.getLowestCompVersion().getValue()) Line 49: .addValue("storage_domain_id", ovfEntityData.getStorageDomainId()) Line 50: .addValue("ovf_extra_data", ovfEntityData.getOvfExtraData())); better to add comment why "ovf_data" isn't listed here. Line 51: } Line 52: Line 53: private static class OvfEntityDataRowMapper implements RowMapper<OvfEntityData> { Line 54: public static final OvfEntityDataRowMapper instance = new OvfEntityDataRowMapper(); http://gerrit.ovirt.org/#/c/26480/16/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 3586: <null /> Line 3587: </row> Line 3588: </table> Line 3589: Line 3590: <table name="unregistered_ovf_of_entities"> see comment in previous patchset Line 3591: <column>entity_guid</column> Line 3592: <column>entity_name</column> Line 3593: <column>entity_type</column> Line 3594: <column>architecture</column> -- To view, visit http://gerrit.ovirt.org/26480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
