Alon Bar-Lev has posted comments on this change. Change subject: dwh: Split of engine-setup-plugin ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/28242/2/ovirt-engine-dwh.spec.in File ovirt-engine-dwh.spec.in: Line 102 Line 103 Line 104 Line 105 Line 106 notice: this should also be updated to the recent id at master. Line 237: %{_initddir}/ovirt-engine-dwhd Line 238: %endif Line 239: Line 240: %files setup Line 241: %dir %{_datadir}/ovirt-engine/setup/ovirt_engine_setup/dwh/ you do not need this if you have bellow, only when you select files. Line 242: %{_datadir}/ovirt-engine/setup/ovirt_engine_setup/dwh/ Line 243: %{_datadir}/ovirt-engine/setup/plugins/*/ovirt-engine-dwh/ Line 244: Line 245: %changelog http://gerrit.ovirt.org/#/c/28242/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 64: condition=lambda self: ( Line 65: self.environment[odwhcons.CoreEnv.ENABLE] and Line 66: not self.environment[oengcommcons.EngineDBEnv.NEW_DATABASE] Line 67: # TODO: ES: check what should happen Line 68: # when the Engine is on a different host this does not belong here. and part of future work anyway... Line 69: ), Line 70: ) Line 71: def _validation(self): Line 72: statement = database.Statement( http://gerrit.ovirt.org/#/c/28242/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/system/environment.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/system/environment.py: Line 58: ) Line 59: self.environment.setdefault( Line 60: odwhcons.SystemEnv.GROUP_DWH, Line 61: dwhGroup Line 62: ) I am unsure this does not belong to the engine common... however, it will enable running dwh and engine using different users... but I think this split belongs to future patch if needed, for now we can keep use the same. Line 63: Line 64: -- To view, visit http://gerrit.ovirt.org/28242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e53dd09940697fe6ef73ed63ef4369e73b02c42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
