Simone Tiraboschi has posted comments on this change. Change subject: dwh: Split of engine-setup-plugin ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28242/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/system/environment.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/system/environment.py: Line 58: ) Line 59: self.environment.setdefault( Line 60: odwhcons.SystemEnv.GROUP_DWH, Line 61: dwhGroup Line 62: ) > I am unsure this does not belong to the engine common... however, it will e In this case I need to move that constant under oenginecommon in the engine split patch; reports also needs it and so it probably the better solution. In this case I need to check that also this code (that indeed sounds duplicated) is just under the engine-common plugin. Line 63: Line 64: -- To view, visit http://gerrit.ovirt.org/28242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e53dd09940697fe6ef73ed63ef4369e73b02c42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
