Shahar Havivi has posted comments on this change. Change subject: core: Extract hardcoded strings to constants ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28281/3/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java: Line 145: if (UPTIME.equals(fieldName) || CREATIONDATE.equals(fieldName)) { Line 146: return BiggerOrSmallerRelationAutoCompleter.INSTANCE; Line 147: } else if (CPU_USAGE.equals(fieldName) || MEM_USAGE.equals(fieldName) Line 148: || MEM_USAGE.equals(fieldName) || NETWORK_USAGE.equals(fieldName) Line 149: || MIGRATION_PROGRESS_PERCENT.equals(fieldName)) { the addition MIGRATION_PROGRESS_PERCENT.equals(fieldName) should be another patch as Omer comment. Line 150: return NumericConditionRelationAutoCompleter.INSTANCE; Line 151: } else if (TAG.equals(fieldName)) { Line 152: return StringOnlyEqualConditionRelationAutoCompleter.INSTANCE; Line 153: } else { -- To view, visit http://gerrit.ovirt.org/28281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d2fb964cc0c5520e37cd190e88f09d4218868d2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
