Omer Frenkel has posted comments on this change. Change subject: core: Extract hardcoded strings to constants ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28281/4/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java: Line 136: public IAutoCompleter getFieldRelationshipAutoCompleter(String fieldName) { Line 137: if (UPTIME.equals(fieldName) || CREATIONDATE.equals(fieldName)) { Line 138: return BiggerOrSmallerRelationAutoCompleter.INSTANCE; Line 139: } else if (CPU_USAGE.equals(fieldName) || MEM_USAGE.equals(fieldName) Line 140: || MEM_USAGE.equals(fieldName) || NETWORK_USAGE.equals(fieldName)) { should be memory (you have mem_usage twice) Line 141: return NumericConditionRelationAutoCompleter.INSTANCE; Line 142: } else if (TAG.equals(fieldName)) { Line 143: return StringOnlyEqualConditionRelationAutoCompleter.INSTANCE; Line 144: } else { -- To view, visit http://gerrit.ovirt.org/28281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d2fb964cc0c5520e37cd190e88f09d4218868d2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
