Alon Bar-Lev has posted comments on this change.
Change subject: kdump: Add kdump plugin
......................................................................
Patch Set 2:
regarding configuration.
for simplicity we override the entire:
fence_kdump_args
fence_kdump_nodes
lines. no need to parse anything. these can appear only once anyway and do not
support multiple configuration.
so again... algorithm is:
#ovirt-host-deploy:backup-begin
#old content
#old content
#ovirt-host-deploy:backup-end
hasSignature = False
backup = []
content = []
read line
if key in ('fence_kdump_args', fence_kdump_args)':
backup.append(line)
elif line is signature:
hasSignature = True
else:
content.append(line)
if not hasSignature:
content.append('#ovirt-host-deploy:backup-begin')
content.extend(['#' + l for l in backup])
content.append('#ovirt-host-deploy:backup-end')
content.append('your new settings')
--
To view, visit http://gerrit.ovirt.org/28385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idda48cb053c7e8747de5434c3681403f739c06b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
