Alon Bar-Lev has posted comments on this change. Change subject: kdump: Add kdump plugin ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/28385/3/src/plugins/ovirt-host-deploy/core/offlinepackager.py File src/plugins/ovirt-host-deploy/core/offlinepackager.py: Line 67: 'epoch': '0', Line 68: 'arch': 'noarch', Line 69: }, Line 70: ] Line 71: elif tuple(patterns) == ('kexec-tools',): > AFAIK, ovirt-node has 2 versions, one is built from rhel6 and one from fedo there are pre-releases so as long as there is no package for these, please return empty. Line 72: return [ Line 73: { Line 74: 'operation': 'installed', Line 75: 'display_name': 'kexec-tools', http://gerrit.ovirt.org/#/c/28385/3/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 24: import gettext Line 25: import platform Line 26: import re Line 27: Line 28: from distutils.version import LooseVersion > LooseVersion is used in the same way in vdsm/packages.py plugin. I really d true! it is bad there as well. I was sure we fixed it. ok leave it this way. Line 29: Line 30: from otopi import util Line 31: from otopi import plugin Line 32: from otopi import constants as otopicons Line 118: # line with fence_kdump config backup begin/end Line 119: if fk_bck_m.group('value') == 'begin': Line 120: inside_backup = True Line 121: else: Line 122: inside_backup = False > Currently all backup lines are inserted between '#ovirt-host-deploy:begin' why? you should not backup the backup, you should only detect the backup and if exist not backup again. I wrote the algorithm previously. line1 line2 -> #backup-begin #line1 #line2 #backup-end line1 modified line2 modified -> #backup-begin #line1 #line2 #backup-end line1 modified again line2 modified again Line 123: else: Line 124: if inside_backup: Line 125: backup.append(line) Line 126: else: -- To view, visit http://gerrit.ovirt.org/28385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idda48cb053c7e8747de5434c3681403f739c06b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
