Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: refactor db credentials questions ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/28261/6/packaging/setup/ovirt_engine_setup/engine_common/database.py File packaging/setup/ovirt_engine_setup/engine_common/database.py: Line 246: if environment is None Line 247: else environment Line 248: ) Line 249: self._dbenvkeys = dbenvkeys Line 250: self._defaults = defaultdbenvkeys what's the different between dbenvkeys and defaultdbenvkeys? also _defaults is quite misleading it is _defaults_dbenvkeys at best case. why can't we provide this to the getCredentials? why do we need this as class state? Line 251: Line 252: def detectCommands(self): Line 253: self.command.detect('pg_dump') Line 254: self.command.detect('pg_restore') Line 667: Line 668: if host is None: Line 669: while True: Line 670: host = self.dialog.queryString( Line 671: name='{qpref}HOST'.format(qpref=queryprefix), please do not use .format with non gettext, or use gettext. can't we use the database name as this prefix? so all queries will be: OVIRT_@database@_XXX it should be unique Line 672: note=_( Line 673: '{name} database host [@DEFAULT@]: ' Line 674: ).format( Line 675: name=name, -- To view, visit http://gerrit.ovirt.org/28261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1451e581a89b750ab34c09e34faeb77403909f00 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
