Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: refactor db credentials questions ......................................................................
Patch Set 6: (1 comment) again, please do not push if you have opened issues. http://gerrit.ovirt.org/#/c/28261/6/packaging/setup/ovirt_engine_setup/engine_common/database.py File packaging/setup/ovirt_engine_setup/engine_common/database.py: Line 667: Line 668: if host is None: Line 669: while True: Line 670: host = self.dialog.queryString( Line 671: name='{qpref}HOST'.format(qpref=queryprefix), > Please be more specific. I do not see how to do that without passing anothe all we need is unique string, you mean the naming of OVESETUP and such? can't we get this from dbkeys? it may be usable for others as well and there we have customizations. Line 672: note=_( Line 673: '{name} database host [@DEFAULT@]: ' Line 674: ).format( Line 675: name=name, -- To view, visit http://gerrit.ovirt.org/28261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1451e581a89b750ab34c09e34faeb77403909f00 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
