Juan Hernandez has posted comments on this change.
Change subject: packaging: Moving to use execCmd in all scripts (#731686)
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
See two minor comments inside.
....................................................
File packaging/fedora/setup/common_utils.py
Line 661: cmd = [basedefs.FILE_RHEVM_CONFIG_BIN, '-s', key + '=' + value,
'--cver=' + basedefs.VDC_OPTION_CVER, '-p', basedefs.FILE_RHEVM_EXTENDED_CONF]
Can you break this long line, one parameter per line, like you do in the other
command?
Line 685: cmd = [basedefs.EXEC_RPM, "-q", "--queryformat",
"'%%{VERSION}-%%{RELEASE}'", rpmName]
Can you break this long line?
--
To view, visit http://gerrit.ovirt.org/4943
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5428890f9dcf8eafaa1ab059ee5d9e84f3f7f9a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
