Ofer Schreiber has posted comments on this change. Change subject: packaging: Moving to use execCmd in all scripts (#731686) ......................................................................
Patch Set 4: Fails (3 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 666: '-p', basedefs.FILE_RHEVM_EXTENDED_CONF, should be another line .................................................... File packaging/fedora/setup/engine-setup.py Line 986: cmd = ["/bin/sh", basedefs.DIR_DB_SCRIPTS + "/" + basedefs.FILE_DB_UPGRADE_SCRIPT] + dbScriptArgs Please check if we really need the /bin/sh Line 1099: output, rc = utils.execCmd(cmd, None, True, msg, masked_value_set) please get rid of /bin/sh -- To view, visit http://gerrit.ovirt.org/4943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5428890f9dcf8eafaa1ab059ee5d9e84f3f7f9a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
