Roy Golan has posted comments on this change.
Change subject: core: added tests to updateVmCommand
......................................................................
Patch Set 2: Looks good to me, approved
(2 inline comments)
minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 236: if (retValue && vm.getnum_of_monitors() <
vmStaticDataFromParams.getnum_of_monitors()) {
nice - don't go to the Db in anyway we failed
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
Line 223: .contains(msg.toString()));
use name() instead. toString() can be overridden
--
To view, visit http://gerrit.ovirt.org/5442
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id37898c28a22ccf19342b8b1a2e40a6b9186bb50
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
