Allon Mureinik has posted comments on this change.
Change subject: core: added tests to updateVmCommand
......................................................................
Patch Set 2: (5 inline comments)
Like this patch.
A lot.
+900 for the concept.
See some inline commenets, though.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
Line 62: mockConfig(ConfigValues.SupportedClusterLevels,
Please you the constants Version.v2_2 Version.v3_0 and Version.v3_1.
Line 65: mockConfig(ConfigValues.VM32BitMaxMemorySizeInMB, 20480),
consider using them here too, in all these configuration values.
Line 95: command = spy(new
UpdateVmCommand<VmManagementParametersBase>(params)
two questions:
1. minor (why is "{" in a new line? we ain't writing C anymore.
2. why is getVdsGroup implemented here and not with spying?
Line 150: doReturn(vdsDAO).when(command).getVdsDAO();
this is redundent - it's mockito's default behavior.
just document this is what happens here.
Line 231: private void mockValidateCustomProperties() {
use generics - Collections.<ValidationErrors>emptyList()
--
To view, visit http://gerrit.ovirt.org/5442
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id37898c28a22ccf19342b8b1a2e40a6b9186bb50
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
