Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Allow separate hosts for dwh/reports ......................................................................
Patch Set 10: (4 comments) http://gerrit.ovirt.org/#/c/27502/10/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 940: %{engine_data}/setup/bin/ovirt-engine-setup Line 941: %{engine_data}/setup/bin/ovirt-engine-setup.env Line 942: %{engine_data}/setup/ovirt_engine_setup/*.py* Line 943: %{engine_data}/setup/plugins/*/base/ Line 944: %{engine_data}/firewalld/ovirt-engine/ if this is at setup base it should not be called ovirt-engine. also in ovirt-enigne there are artifacts that belongs to ovirt-engine and just for it. please split it in correctly. Line 945: %{engine_state}/backups/ Line 946: %{engine_state}/setup/ Line 947: Line 948: %files setup http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/ovirt_engine_setup/engine_common/constants.py File packaging/setup/ovirt_engine_setup/engine_common/constants.py: Line 46: Line 47: OVIRT_ENGINE_SYSCTL = os.path.join( Line 48: SYSCONFDIR, Line 49: 'sysctl.d', Line 50: 'ovirt-engine.conf', so this should be renamed to to avoid conflict with potential ovirt-engine specific. a file per purpose would be nicer, I think this is used only for postgresql now, so ovirt-postgres.conf will be better. Line 51: ) Line 52: Line 53: Line 54: @util.export http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py: Line 91: { Line 92: 'name': 'ovirt-jboss-https', Line 93: 'directory': 'ovirt-engine' Line 94: }, Line 95: ]) these are ovirt-engine specific purely... Line 96: Line 97: http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py: Line 161: ) Line 162: Line 163: raise RuntimeError( Line 164: _('Unable to set sysctl kernel.shmmax to minimum requirement') Line 165: ) we only deal with postgres, we can move this either to provisioning or to any other postgres specific. and anyway, this is engine specific as without engine we do not need this setting anyway... :) Line 166: Line 167: def _get_shmmax(self): Line 168: rc, shmmax, stderr = self.execute( Line 169: ( -- To view, visit http://gerrit.ovirt.org/27502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbcf1ae9e442d9ab3ab11a8fd68bde4ebc69cdad Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
