Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: Allow separate hosts for dwh/reports
......................................................................


Patch Set 10:

(2 comments)

http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py:

Line 91:                 {
Line 92:                     'name': 'ovirt-jboss-https',
Line 93:                     'directory': 'ovirt-engine'
Line 94:                 },
Line 95:             ])
> Don't we open jboss http and https on the host running reports?
we need one set for engine and other set for reports, the fact that both are 
opening 80 or not is irrelevant, each can have its own ports.
Line 96: 
Line 97: 


http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py:

Line 161:             )
Line 162: 
Line 163:             raise RuntimeError(
Line 164:                 _('Unable to set sysctl kernel.shmmax to minimum 
requirement')
Line 165:             )
> We need also on DWH and reports if we provision postgres on the separate ho
as far as I know the shmmax issue is because of how the engine behaves. and 
anyway, it only set where the postgres is.
Line 166: 
Line 167:     def _get_shmmax(self):
Line 168:         rc, shmmax, stderr = self.execute(
Line 169:             (


-- 
To view, visit http://gerrit.ovirt.org/27502
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbcf1ae9e442d9ab3ab11a8fd68bde4ebc69cdad
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to