Michael Pasternak has posted comments on this change.
Change subject: restapi: Fix update cluster network (#822631)
......................................................................
Patch Set 1: Do not submit
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResource.java
Line 32: new
AttachNetworkToVdsGroupParameter(cluster.getVDSGroup(), map(incoming,
map(get()))));
suggested patch is non RESTful [1] and logically invalid [2],
1. attach of network to cluster performed via POST /api/clusters/xxx/networks
(done at BackendClusterNetworksResource)
2. you trying to perform another VdcActionType.AttachNetworkToVdsGroup
on already attached BackendClusterNetworkResource (otherwise this resource
wouldn't exist)
3. you not performing here "updating of cluster's network assignmen", but
UPDATE of network resource (in cluster context),
if you want to assign this network to another cluster as well, it should
be done via this cluster /networks collection =>
POST /api/clusters/yyy/networks
--
To view, visit http://gerrit.ovirt.org/5513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba860433d0a77caad6405fb30b9b29b0af3a847
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
