Michael Pasternak has posted comments on this change.
Change subject: restapi: Fix update cluster network (#822631)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResource.java
Line 32: new
AttachNetworkToVdsGroupParameter(cluster.getVDSGroup(), map(incoming,
map(get()))));
the goal of AttachNetworkToVdsGroup is to attach Network to cluster, if it's
updating few other things it's irrelevant (btw i would expect to see
can-do-action: "network already attach to this cluster" on second
AttachNetworkToVdsGroup ...),
the bug is about missing ability of updating certain field in attached network,
two possible solutions that i see:
1. allow update() of network in this context, but then you'll have to make
sure that properties that cannot be updated in Cluseter/Network context
not get updated
2. add new verb (as was done for /display/ to avoid collisions mentioned in 1)
--
To view, visit http://gerrit.ovirt.org/5513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba860433d0a77caad6405fb30b9b29b0af3a847
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
