Federico Simoncelli has posted comments on this change.
Change subject: core: Run upgradeStoragePool on cluster compatibility change
......................................................................
Patch Set 16: (10 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 31:
Done
Line 52: updateDefaultQuota();
Done
Line 54: if (getStoragePool().getstatus() == StoragePoolStatus.Up) {
Done
Line 113: StorageType spType = storagePool.getstorage_pool_type();
This is not an error, this is a noop (which means that the DC should be
switched to 3.1 but the domain format on the storage is not updated).
Line 121: getStoragePoolDAO().update(storagePool);
Done
Line 130: // as VDSM will silently ignore the request
Done
Line 145:
Done
Line 152: }
Done
Line 164: @Override
Let's address that in another patch.
Line 167: _oldStoragePool =
getStoragePoolDAO().get(getStoragePool().getId());
Done
--
To view, visit http://gerrit.ovirt.org/2441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85201624bbb2f8c41cf3b184b89a8e199ff50e99
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
