Allon Mureinik has posted comments on this change.
Change subject: core: Run upgradeStoragePool on cluster compatibility change
......................................................................
Patch Set 18: I would prefer that you didn't submit this
(5 inline comments)
see inline.
In addition, I'd like to see a unit test for the command you changed.
You're introducing a lot of new logic here.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 105: if (Version.OpEquality(spVersion, oldSpVersion)) {
This condition infers that updateStoragePoolFormatType() may in fact do
nothing. I'd separate this logic to a different method, called from
executeCommand(). E.g.:
if (updateStoragePoolFormatTypeNeeded() {
updateStoragePoolFormatType();
}
Line 110: // when everyone can utilize it.
Agree with the TODO comment - let's do it :-)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpgradeStoragePoolVDSCommandParameters.java
Line 4: import org.ovirt.engine.core.common.businessentities.*;
Use FQCN imports, not *.
Eclipse IDE can be configured to do this automatically if you like.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java
Line 336: .addValue("storage_pool_format_type",
pool.getStoragePoolFormatType())
The format type is not supported by the underlying stored procedure - you need
to add it there too.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpgradeStoragePoolVDSCommand.java
Line 23: private static Log log =
LogFactory.getLog(UpgradeStoragePoolVDSCommand.class);
Make the log final
--
To view, visit http://gerrit.ovirt.org/2441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85201624bbb2f8c41cf3b184b89a8e199ff50e99
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
