Alon Bar-Lev has posted comments on this change. Change subject: core: introduce context pattern ......................................................................
Patch Set 21: (2 comments) http://gerrit.ovirt.org/#/c/28829/21/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 121: private List<QuotaConsumptionParameter> consumptionParameters; Line 122: /** Indicates whether the acquired locks should be released after the execute method or not */ Line 123: private boolean releaseLocksAtEndOfExecute = true; Line 124: /** Object which is representing a lock that some commands will acquire */ Line 125: // private EngineLock commandLock; ? Line 126: Line 127: protected Log log = LogFactory.getLog(getClass()); Line 128: Line 129: /** The context defines how to monitor the command and handle its compensation */ Line 126: Line 127: protected Log log = LogFactory.getLog(getClass()); Line 128: Line 129: /** The context defines how to monitor the command and handle its compensation */ Line 130: private CommandContext context = null; final please Line 131: Line 132: /** A map contains the properties for describing the job */ Line 133: protected Map<String, String> jobProperties; Line 134: -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
