Alon Bar-Lev has posted comments on this change.

Change subject: core: introduce context pattern
......................................................................


Patch Set 25:

(3 comments)

http://gerrit.ovirt.org/#/c/28829/25/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java:

Line 91
Line 92
Line 93
Line 94
Line 95
consider:

 return setCompensationContext(new DefaultCompensationContext());


Line 99
Line 100
Line 101
Line 102
Line 103
consider:

 return setExecutionContext(new ExecutionContext());


Line 83:         return this;
Line 84:     }
Line 85: 
Line 86:     public CommandContext resetLock() {
Line 87:         this.lock = new EngineLock();
consider:

 return setLock(new EngineLock());
Line 88:         return this;
Line 89:     }
Line 90: 
Line 91:     public EngineLock getLock() {


-- 
To view, visit http://gerrit.ovirt.org/28829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to