Maor Lipchuk has posted comments on this change. Change subject: core: Add an audit log entry when number of LVs on a domain exceeded max ......................................................................
Patch Set 1: Regard my comment above, The reason I think it is risky is that you need to make sure that there are no commands which are transactive, and add an audit log which after that calling a VDS command, otherwise we will have a dead lock. We also need to make sure that all future commands will not behave like that, so I prefer that we will save the trouble. -- To view, visit http://gerrit.ovirt.org/29057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie701a4b622b4f93690020922f96279d28903abc8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
