Maor Lipchuk has posted comments on this change. Change subject: core: Add an audit log entry when number of LVs on a domain exceeded max ......................................................................
Patch Set 2: (4 comments) What about the audit log issue I mentioned before in the patch cover message, is it safe? http://gerrit.ovirt.org/#/c/29057/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java: Line 14: } Line 15: Line 16: @Override Line 17: protected void executeIrsBrokerCommand() { Line 18: StorageDomainHelper.checkNumberOfLVsForBlockDomain(getParameters().getDstStorageDomainId()); What about the audit log issue I mentioned before is it safe? Line 19: /** Line 20: * TODO: EINAV: - Consider 'RunAsync' parameter (pass it to IRS too). - Add 'description' parameter. - we should Line 21: * provide 'volumeUUID'. - TaskID should be provided by IRS. Line 22: */ http://gerrit.ovirt.org/#/c/29057/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java: Line 14: } Line 15: Line 16: @Override Line 17: protected void executeIrsBrokerCommand() { Line 18: StorageDomainHelper.checkNumberOfLVsForBlockDomain(getParameters().getStorageDomainId()); What about the audit log issue I mentioned before is it safe? Line 19: setReturnValue(Guid.Empty); Line 20: Line 21: log.info("-- executeIrsBrokerCommand: calling 'createVolume' with two new parameters: description and UUID"); Line 22: // NOTE: The 'uuidReturn' variable will contain the taskID and not the http://gerrit.ovirt.org/#/c/29057/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java: Line 14: } Line 15: Line 16: @Override Line 17: protected void executeIrsBrokerCommand() { Line 18: StorageDomainHelper.checkNumberOfLVsForBlockDomain(getParameters().getStorageDomainId()); What about the audit log issue I mentioned before is it safe? Line 19: setReturnValue(Guid.Empty); Line 20: Line 21: log.info("-- executeIrsBrokerCommand: calling 'createVolume' with two new parameters: description and UUID"); Line 22: // NOTE: The 'uuidReturn' variable will contain the taskID and not http://gerrit.ovirt.org/#/c/29057/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java: Line 12: } Line 13: Line 14: @Override Line 15: protected void executeIrsBrokerCommand() { Line 16: StorageDomainHelper.checkNumberOfLVsForBlockDomain(getParameters().getDstDomainId()); What about the audit log issue I mentioned before is it safe? Line 17: uuidReturn = getIrsProxy().moveImage(getParameters().getStoragePoolId().toString(), Line 18: getParameters().getStorageDomainId().toString(), Line 19: getParameters().getDstDomainId().toString(), Line 20: getParameters().getImageGroupId().toString(), -- To view, visit http://gerrit.ovirt.org/29057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie701a4b622b4f93690020922f96279d28903abc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
