Allon Mureinik has posted comments on this change. Change subject: core: Use configuration for Import Storage Domain ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/29020/2//COMMIT_MSG Commit Message: Line 7: core: Use configuration for Import Storage Domain Line 8: Line 9: Add a new configuration value for Import Storage Domain. Line 10: Import Storage Domain should be supported only with Hosts that are in Line 11: 3.5 clusters. Actually, forceDetach is an SPM verb - you should check the DATACENTER comp. version, not the cluser comp. version. Line 12: Line 13: Change-Id: I4b1824320223c915b97e0ea487abec285cea31e5 http://gerrit.ovirt.org/#/c/29020/2/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 840: ACTION_TYPE_FAILED_INVALID_VDS_HOSTNAME=Can not ${action} ${type}. The given Host name is invalid. Only Host names corresponding to RFC-952 and RFC-1123 are allowed. Line 841: ACTION_TYPE_FAILED_INVALID_POOL_NAME=Can not ${action} ${type}. The given name is invalid for pool name. Only lower-case and upper-case letters, numbers, '_', '-', '.', and one mask sequence are allowed. Line 842: VM_CANNOT_RUN_ONCE_WITH_ILLEGAL_SYSPREP_PARAM=Missing UserName or Password. Line 843: ACTION_TYPE_FAILED_CANNOT_REMOVE_BUILTIN_GROUP_EVERYONE=Cannot remove the built-in group "Everyone". Line 844: ACTION_TYPE_FAILED_IMPORT_DATA_DOMAIN_IS_NOT_SUPPORTED=Cannot ${action} ${type}. The operation is not supported for this cluster version. s/cluster/DC/ Line 845: ACTION_TYPE_FAILED_VDS_NOT_MATCH_VALID_STATUS=Cannot ${action} ${type}. Valid Host statuses are "Non operational", "Maintenance" or "Connecting". Line 846: CANNOT_REMOVE_STORAGE_DOMAIN_INVALID_HOST_ID=Can not Remove Storage Domain - the underlying Host ID is invalid. Line 847: ERROR_CANNOT_DEACTIVATE_MASTER_WITH_LOCKED_DOMAINS=You are trying to deactivate a Master storage domain while there are locked domains in the Data Center. Please wait for the operations on those domains to finish first. Line 848: TAGS_CANNOT_REMOVE_TAG_NOT_EXIST=Cannot remove tag. Tag does not exist. -- To view, visit http://gerrit.ovirt.org/29020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b1824320223c915b97e0ea487abec285cea31e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
