Allon Mureinik has posted comments on this change. Change subject: core: Use configuration for Import Storage Domain ......................................................................
Patch Set 7: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/29020/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java: Line 60: Line 61: protected boolean checkExistingStorageDomain() { Line 62: // Prevent importing DATA domain if cluster version is not supported. Line 63: if (getParameters().getStorageDomain().getStorageDomainType() == StorageDomainType.Data Line 64: && !FeatureSupported.importDataStorageDomain(getVds().getVdsGroupCompatibilityVersion())) { Should be done vs. the DC compatibility version. Line 65: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_IMPORT_DATA_DOMAIN_IS_NOT_SUPPORTED); Line 66: } Line 67: Line 68: if (DbFacade.getInstance().getStorageDomainStaticDao().get(getStorageDomain().getId()) != null) { -- To view, visit http://gerrit.ovirt.org/29020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b1824320223c915b97e0ea487abec285cea31e5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
