Ayal Baron has posted comments on this change.
Change subject: core: UnPowerMock and clean pools with vm commands
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
Line 221: if (!isMemorySizeLegal(grp, vmStaticData)) {
for once a method gets only the params it really needs to work, why change that
to passing everything under the sun?
Line 240: if (!verifyAddVM(grp)) {
same as above
Line 252: if (!storageIds.contains(storageId) &&
!areTemplateImagesInStorageReady(storageId)) {
I thought the convention is to always use 'is' regardless of plurality (I have
no problem with it if it's not the case)
--
To view, visit http://gerrit.ovirt.org/5517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43cdf43682d3ab2a3e75ca965490982888b93763
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
