Yair Zaslavsky has posted comments on this change.
Change subject: core: UnPowerMock and clean pools with vm commands
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
Line 252: if (!storageIds.contains(storageId) &&
!areTemplateImagesInStorageReady(storageId)) {
Ayal - AFAIK "is" is crucial for Java bean notation which is assumed for
getters (getter of boolean may begin with "is" or "get) and required by various
frameworks (Hibernate, JAXB and others).
For a boolean method that is not a getter - feel free to use whatever you want.
If we want to introduce an internal convention - that's something else.
--
To view, visit http://gerrit.ovirt.org/5517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43cdf43682d3ab2a3e75ca965490982888b93763
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
